Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

minimal webfinger #5373

Merged
merged 23 commits into from
Feb 13, 2023
Merged

minimal webfinger #5373

merged 23 commits into from
Feb 13, 2023

Conversation

butonic
Copy link
Member

@butonic butonic commented Jan 10, 2023 •
edited
Loading

This is a minimal implementation of webfinger RFC7033.
It returns the openid connect issuer relation and one or more owncloud instance relation when the request was authenticated. For more details and configuration examples see the README.md

Most of this is boilerplate for a new service. For a review start at:

  • pkg/services/v0/services.go
  • pkg/relations/openid-discovery.go
  • pkg/relations/owncloud-instance.go

@butonic butonic self-assigned this Jan 10, 2023
@update-docs
Copy link

update-docs bot commented Jan 10, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@ownclouders
Copy link
Contributor

ownclouders commented Jan 10, 2023 •
edited
Loading

💥 Acceptance test localApiTests-apiSpacesShares-ocis failed. Further test are cancelled...

@michaelstingl
Copy link
Contributor

@felix-schwarz @fmoc @dschmidt @TheOneRing FYI

@butonic butonic mentioned this pull request Jan 11, 2023
Merged
@michaelstingl michaelstingl linked an issue Jan 19, 2023 that may be closed by this pull request
[ocis] webfinger service #5281
Closed
3 tasks
@butonic butonic added the Category:Enhancement Add new functionality label Jan 31, 2023
@dkocher dkocher mentioned this pull request Feb 1, 2023
Open
7 tasks
@butonic butonic changed the title initial webfinger stub minimal webfinger Feb 3, 2023
dschmidt
dschmidt reviewed Feb 8, 2023
View reviewed changes
services/webfinger/README.md Outdated Show resolved Hide resolved
services/webfinger/README.md Outdated Show resolved Hide resolved
services/webfinger/README.md Outdated Show resolved Hide resolved
@butonic
initial webfinger stub
ffd292d 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
add webfinger to proxy, return current host
d2c3f10 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
some cleanup
dc15080 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
allow passing multiple rel params
5d70f0d 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
introduce interfaces
9a8cd17 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
parse oidc auth token
106d985 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
add templating, drop chain, use map of relation providers
b11eeaa 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic and others added 5 commits February 9, 2023 21:46
@butonic
fix ocis url yaml
6670419 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic @dschmidt
fix typos
ee97f6f 
Co-authored-by: Dominik Schmidt <[email protected]>
@butonic
switch to userinfo claims
0b91c93 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
readme cleanup
492a409 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
add TODO.md with ideas
bf38987 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic and others added 3 commits February 10, 2023 09:11
@butonic
replace subject on authenticated request responses
1aa70d2 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic @mmattel
Apply suggestions from code review
05b5be4 
Co-authored-by: Martin <[email protected]>
@butonic
markdown lint
c00afed 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
mmattel
mmattel reviewed Feb 10, 2023
View reviewed changes
services/webfinger/TODO.md Outdated Show resolved Hide resolved
mmattel
mmattel reviewed Feb 10, 2023
View reviewed changes
services/webfinger/TODO.md Outdated Show resolved Hide resolved
butonic and others added 6 commits February 10, 2023 11:26
@butonic
return a 401 when bearer token expired, some more docs
1fb4e9d 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic @mmattel
Apply suggestions from code review
5037144 
Co-authored-by: Martin <[email protected]>
@butonic
fix docs
1e013c8 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
clarify env var
e947e82 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
extract handler func
7f6d702 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic
use correct service in reflex.conf
abb42c1 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
Excds
Excds suggested changes Feb 10, 2023
View reviewed changes
services/webfinger/README.md Show resolved Hide resolved
@butonic
test relations
a4741da 
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
@butonic butonic requested a review from Excds February 10, 2023 14:35
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.3% 0.3% Coverage
1.6% 1.6% Duplication

@butonic butonic merged commit 2c98d32 into master Feb 13, 2023
@delete-merged-branch delete-merged-branch bot deleted the webfinger branch February 13, 2023 10:05
@mmattel
Copy link
Contributor

mmattel commented Feb 13, 2023

Q: dont we need entries in:

I stumbled across this as we needed to add that for the postprocessing service so that stuff will get included in the automated doc processing...

ownclouders pushed a commit that referenced this pull request Feb 13, 2023
@butonic
commit 2c98d32
f2d6936 
Author: Jörn Friedrich Dreyer <[email protected]>
Date:   Mon Feb 13 11:05:20 2023 +0100

    minimal webfinger (#5373)

    * initial webfinger stub

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * add webfinger to proxy, return current host

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * some cleanup

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * allow passing multiple rel params

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * introduce interfaces

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * parse oidc auth token

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * add templating, drop chain, use map of relation providers

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * fix ocis url yaml

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * fix typos

    Co-authored-by: Dominik Schmidt <[email protected]>

    * switch to userinfo claims

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * readme cleanup

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * add TODO.md with ideas

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * replace subject on authenticated request responses

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * Apply suggestions from code review

    Co-authored-by: Martin <[email protected]>

    * markdown lint

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * return a 401 when bearer token expired, some more docs

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * Apply suggestions from code review

    Co-authored-by: Martin <[email protected]>

    * fix docs

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * clarify env var

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * extract handler func

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * use correct service in reflex.conf

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * test relations

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>

    * Update services/webfinger/pkg/config/config.go

    ---------

    Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
    Co-authored-by: Dominik Schmidt <[email protected]>
    Co-authored-by: Martin <[email protected]>
This was referenced Feb 13, 2023
Closed
Merged
@micbar micbar mentioned this pull request May 3, 2023
Closed
89 tasks
@ScharfViktor ScharfViktor mentioned this pull request May 4, 2023
Closed
86 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmattel mmattel mmattel left review comments

@dschmidt dschmidt dschmidt left review comments

@micbar micbar micbar approved these changes

@Excds Excds Excds approved these changes

Assignees

@butonic butonic

Labels
Category:Enhancement Add new functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ocis] webfinger service
7 participants
@butonic @ownclouders @michaelstingl @mmattel @Excds @dschmidt @micbar